Re: RFC: README.SUBMMITING_PATCH

From past experience, I think that telling people to wait a few weeks before resubmitting it not realistic. If they don't get an answer within 3-4 days, chances are they won't get an answer at all, and they should ping us again... Maybe a small online interface for proposing patches (and not losing them) would bring some order to this mess, but then again, it may be an overkill. Zeev At 08:49 18/03/2002, Yasuo Ohgaki wrote:

Hi all, We get questions like "where to send path?" on occasion. We should have doc for that. Here is a draft. Please fix/add/comment. Thank you. ------README.SUBMITTING_PATCH------- Submitting Patch for PHP ======================== This document describes how to submit patch for PHP. How to create patch? -------------------- We are working with CVS. You need to get CVS source to create patch that we accept. Visit http://www.php.net/anoncvs.php to get CVS source. You can check out older versions, but make sure you get default branch (i.e. Do not use -r option when you check out CVS source) Now you are ready to create patch. Modify source to fix bugs in PHP or to add new feature to PHP. After you finished editing and testing your patch, take diff file using "cvs diff > your.patch" command. Make sure you update CVS source before you take final patch. Make sure you don't include white space changes. (i.e. New blank lines, spaces->tab or tab->spaces changes) Read README.TESTING for submitting test script also. Where to send your patch? ------------------------- You are supposed to send patch to php-dev@lists.php.net. If you are patching modules, you should also send patch to the maintainer. Official module maintainers are listed in EXTENSION file in source. How long it will take to get response? -------------------------------------- Since we are volunteers, it may take more than few days to get response. If you didn't get any response in few weeks, please submit your patch again and let us know you have been submitted the patch before. Thank you for sending patch for PHP! -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php