Re: fgetss_state - seemingly unused
| From: | Wez Furlong | Date: | Wed, 20 Mar 2002 12:41:39 +0000 |
| Subject: | Re: fgetss_state - seemingly unused | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-81548@lists.php.net to get a copy of this message | ||
It was my intention to put the state into the stream structure
and nuke the global, so that the state is per stream, which makes
a bit more sense since running two fgetss() in "parallel" would
get confused otherwise.
Are there problems with that?
--Wez.
On 20/03/02, "Rasmus Lerdorf" <rasmus@lerdorf.ca> wrote:
> It is safe to remove, yes, since it doesn't do anything anymore. However,
> the original function was able to parse multi-line tags correctly which
> the current one no longer does.
>
> So instead of just removing it, we should consider re-introducing that
> feature.
>
> -Rasmus
>
> On Wed, 20 Mar 2002, Stefan Roehrich wrote:
>
> > On 2002-03-19 16:40:51, Rasmus Lerdorf wrote:
> > > This is a remnant from my original implementation in PHP 2. It was
> > > committed: Mon May 20 15:20:25 1996 (5 years, 10 months ago)
> >
> > Some code never goes away ;-) ...
> >
> > > Having that level of revision history is actually pretty cool if you ask
> > > me. This is the diff:
> >
> > Yes, it's really nice to have such a long history.
> >
> > > So it did actually make sense at one point. It has just sort of lost its
> > > way over the years.
> >
> > So it should be save to remove the *getss_state variables?
> >
> > Stefan
> >
> > --
> > Stefan Röhrich stefan@roehri.ch, sr@linux.de
> > http://www.roehri.ch/~sr/
> >