Re: Mysql Patch for Multi-User Safety

At 17:34 03/04/2002 +0300, Zeev Suraski wrote:

Problems I could spot:

hey Zeev, nice to talk to you again :)

- You use (*z_user)->value.str.val without making sure that z_user is of type string. You must have convert_to_string_ex(z_user) first (line 159 of the patch) - You don't allocate room for the NULL terminator in tmp_filename (line 188 of the patch)

thanks i've corrected these two problems. I'll try and see what happens now..

Do you know where it crashes? Did you ever get a backtrace?

it crashes when on this line : mysql_init(&mysql->conn); [line 2165 of my patched version] and the backtrace goes up to free() in malloc.c that segfaults... Strange huh ? one wouldn't expect such an atomic function to crash, and yet it does :) Thanks for anymore insight. Later Chand -- Mark Villemade Hosting Services Technical Manager Lycos Europe +33 1 53 27 24 05