Re: Exif doesn't compile

At 21:37 03.04.2002, you wrote:

Hey, seems ok... which library should provide it? (Testing now)

It should be provided by standard-c-library if it has the function wctomb. The function wctomb needs to work on buffers which are at least MB_CUR_MAX characters long. The main problem when definig any constant our self is that we do not know what the library does internally. Normally it should work on not more than 4 bytes but who knows? Will try to check & verify that tomorrow - only problem is that i cannot produce worstcase testdata for that. marcus

Derick On Wed, 3 Apr 2002, Marcus Börger wrote: At 21:05 03.04.2002, you wrote:

Hello Marcus, ext/exif doesn't compile anymore, it can't find the constant MB_CUR_MAX in exif.c (PHP_4_2_0 line 1260, HEAD line 1972). Please fix this as soon as possible. regards, Derick

Try the following diff (should work for both versions even though i made it with 4.2.0). If you can confirm it i check in. But i leave within the next half hour.... marcus cvs -z3 -q diff ext\exif\exif.c (in directory S:\PHP_4_2_0\) Index: ext/exif/exif.c =================================================================== RCS file: /repository/php4/ext/exif/exif.c,v retrieving revision 1.52.2.3 diff -u -r1.52.2.3 exif.c

--- ext/exif/exif.c     30 Mar 2002 18:31:08 -0000      1.52.2.3
+++ ext/exif/exif.c     3 Apr 2002 19:38:01 -0000

@@ -77,6 +77,11 @@

         #define FALSE 0

#endif +#ifndef MB_CUR_MAX

+       #define MB_CUR_MAX      8
+       /* should be a library constant */

+#endif + #define EXIT_FAILURE 1 #define EXIT_SUCCESS 0