ext/exif broken in HEAD.
| From: | Jani Taskinen | Date: | Sun, 07 Apr 2002 16:59:57 +0000 |
| Subject: | ext/exif broken in HEAD. | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-82238@lists.php.net to get a copy of this message | ||
/usr/src/web/php/php4/ext/exif/exif.c: In function `add_assoc_image_info':
/usr/src/web/php/php4/ext/exif/exif.c:1346: warning: `array' might be used uninitialized in
this function
/usr/src/web/php/php4/ext/exif/exif.c: In function `exif_process_user_comment':
/usr/src/web/php/php4/ext/exif/exif.c:2056: warning: implicit declaration of function
`exif_process_string_raw'
/usr/src/web/php/php4/ext/exif/exif.c: In function `exif_process_IFD_TAG':
/usr/src/web/php/php4/ext/exif/exif.c:2238: too few arguments to function
`exif_process_user_comment'
/usr/src/web/php/php4/ext/exif/exif.c:2306: warning: `sub_section_index' might be used
uninitialized in this function
/usr/src/web/php/php4/ext/exif/exif.c: In function `exif_scan_JPEG_header':
/usr/src/web/php/php4/ext/exif/exif.c:2492: warning: `comment_correction' might be used
uninitialized in this function
/usr/src/web/php/php4/ext/exif/exif.c: In function `exif_process_IFD_in_TIFF':
/usr/src/web/php/php4/ext/exif/exif.c:2732: warning: `sub_section_index' might be used
uninitialized in this function
/usr/src/web/php/php4/ext/exif/exif.c:2734: warning: `entry_value' might be used uninitialized
in this function
/usr/src/web/php/php4/ext/exif/exif.c: At top level:
/usr/src/web/php/php4/ext/exif/exif.c:125: warning: `exif_encoding_unicode' defined but not
used
/usr/src/web/php/php4/ext/exif/exif.c:126: warning: `exif_encoding_jis' defined but not used
/usr/src/web/php/php4/ext/exif/exif.c:546: warning: `exif_char_dump' defined but not used
make: *** [ext/exif/exif.lo] Error 1
Also, the ext/exif.c does not follow the coding standards.
Marcus, please read: CODING_STANDARDS.
--Jani