Re: Win32 build broken

Marcus Börger wrote:

No that was S_ISDIR was introduced by me to have this -c option work correctly. I had a short email discussion with Yasuo about the macros i used and their

Oh. I thought S_ISDIR is in .h but in .c :( IMHO, if it's in .c, we are better to use usual way (not use/create macro that has the same name) If nobody objects, I'll remove S_ISDIR macro from php_ini.c. -- Yasuo Ohgaki

availability in Windows and we both thought they are available in Windows. Maybe we have to check whether to use S_ISDIR directly or have it defined using S_IFMT/S_IFDIR which *should* be available in MickySoft. Could you give the following a try please: #ifndef S_ISDIR

#define S_ISDIR( m )    (((m) & S_IFMT) == S_IFDIR)

#endif marcus At 09:57 17.04.2002, Wez Furlong wrote:

On 17/04/02, "Sebastian Bergmann" <sebastian@php.net> wrote:

c:\home\php\php4\main\php_ini.c(271): warning C4013: 'S_ISDIR': undefined php_ini.obj: error LNK2001: Unresolved external symbol _S_ISDIR

I would suspect my last change to main/php.h to be the cause. I moved the stream/wrapper related includes to occur after the definition of MAXPATHLEN so that they can use it. I don't have time to try building under win32 right now; I have a go later this evening. --Wez. -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php