External http auth should not set PHP_AUTH_* vars..

From: Date: Tue, 23 Apr 2002 00:58:28 +0000
Subject: External http auth should not set PHP_AUTH_* vars..
Groups: php.dev 
Request: Send a blank email to php-dev+get-83181@lists.php.net to get a copy of this message
There's a bug report about this: http://bugs.php.net/?id=16653&edit=1 And this patch fixes it..but I was wondering why this line was commented out? Maybe there was some reason? It's been there since revision 1.1. --Jani =================================================================== RCS file: /repository/php4/sapi/apache/mod_php4.c,v retrieving revision 1.127 diff -u -r1.127 mod_php4.c --- mod_php4.c 11 Dec 2001 15:31:53 -0000 1.127 +++ mod_php4.c 23 Apr 2002 00:51:49 -0000 @@ -434,7 +434,7 @@ authorization = table_get(r->headers_in, "Authorization"); } if (authorization -/* && !auth_type(r) */ + && !auth_type(r) && !strcasecmp(getword(r->pool, &authorization, ' '), "Basic")) { tmp = uudecode(r->pool, authorization); SG(request_info).auth_user = getword_nulls_nc(r->pool, &tmp, ':');

« previous php.dev (#83181) next »