bug-system improvements
| From: | Jan Lehnardt | Date: | Thu, 09 May 2002 09:13:44 +0000 |
| Subject: | bug-system improvements | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-83836@lists.php.net to get a copy of this message | ||
Hi,
the attached patch "fixes" two issues in the current bug-system. First,
it makes the "fixedcvs" option compliant with documentation bugs.
Second, an additional note can be addeed to the predefined message. This
gives us the opportunity e.g. to add the related bug report when marking
a bug "duplicate".
Since I lack the sufficient karma I ask to review the patch and either
apply it directly or give me karma to the php-bugs-web cvs module.
Thank you.
Jan
--
Q: Thank Jan? A: http://geschenke.an.dasmoped.net/
Index: fix.php =================================================================== RCS file: /repository/php-bugs-web/fix.php,v retrieving revision 1.6 diff -u -r1.6 fix.php --- fix.php 5 May 2002 17:31:00 -0000 1.6 +++ fix.php 9 May 2002 09:06:04 -0000 @@ -55,6 +55,10 @@ <th>Reason:</th> <td colspan="5"><select name="r"><?php echo show_reason_types($r)?></select></td> </tr> + <tr> + <th>Note:</th> + <td colspan="5"><textarea cols="60" rows="8" name="ncomment" wrap="physical"></textarea></td> + </tr> </table> <input type="submit" value="Resolve" /> </form> @@ -85,7 +89,7 @@ /* update bug record */ $status = $RESOLVE_REASONS[$r]['status']; -$ncomment = $RESOLVE_REASONS[$r]['message']; +$ncomment = $RESOLVE_REASONS[$r]['message'].(!empty($ncomment)?"\n\n".$ncomment:""); /* if the already has the status of the resolution, bounce over to the main bug form. it will show the appropriate error message. */ Index: include/resolve.inc =================================================================== RCS file: /repository/php-bugs-web/include/resolve.inc,v retrieving revision 1.7 diff -u -r1.7 resolve.inc --- include/resolve.inc 4 May 2002 21:43:53 -0000 1.7 +++ include/resolve.inc 9 May 2002 09:06:04 -0000 @@ -6,7 +6,9 @@ 'desc' => 'Fixed in CVS', 'message' => 'This bug has been fixed in CVS. You can grab a snapshot of the -CVS version at http://snaps.php.net/', +CVS version at http://snaps.php.net/. In case this was a documentation +problem, the fix will show up soon at http://www.php.net/manual/. +Thank you for the report.', ), 'alreadyfixed' => array( 'status' => 'Closed',
Index: fix.php =================================================================== RCS file: /repository/php-bugs-web/fix.php,v retrieving revision 1.6 diff -u -r1.6 fix.php --- fix.php 5 May 2002 17:31:00 -0000 1.6 +++ fix.php 9 May 2002 09:06:04 -0000 @@ -55,6 +55,10 @@ <th>Reason:</th> <td colspan="5"><select name="r"><?php echo show_reason_types($r)?></select></td> </tr> + <tr> + <th>Note:</th> + <td colspan="5"><textarea cols="60" rows="8" name="ncomment" wrap="physical"></textarea></td> + </tr> </table> <input type="submit" value="Resolve" /> </form> @@ -85,7 +89,7 @@ /* update bug record */ $status = $RESOLVE_REASONS[$r]['status']; -$ncomment = $RESOLVE_REASONS[$r]['message']; +$ncomment = $RESOLVE_REASONS[$r]['message'].(!empty($ncomment)?"\n\n".$ncomment:""); /* if the already has the status of the resolution, bounce over to the main bug form. it will show the appropriate error message. */ Index: include/resolve.inc =================================================================== RCS file: /repository/php-bugs-web/include/resolve.inc,v retrieving revision 1.7 diff -u -r1.7 resolve.inc --- include/resolve.inc 4 May 2002 21:43:53 -0000 1.7 +++ include/resolve.inc 9 May 2002 09:06:04 -0000 @@ -6,7 +6,9 @@ 'desc' => 'Fixed in CVS', 'message' => 'This bug has been fixed in CVS. You can grab a snapshot of the -CVS version at http://snaps.php.net/', +CVS version at http://snaps.php.net/. In case this was a documentation +problem, the fix will show up soon at http://www.php.net/manual/. +Thank you for the report.', ), 'alreadyfixed' => array( 'status' => 'Closed',