Re: cvs: php4 /ext/standard head.c

On Fri, 17 May 2002, Rasmus Lerdorf wrote: > > - return sapi_add_header(cookie, strlen(cookie), 0); > > + return sapi_add_header_ex(cookie, strlen(cookie), 0, 0 TSRMLS_CC); > > Yikes, what a suspicious looking patch! This has been wrong all along for > all SAPI modules, but works, at least for the Apache 1.x case because > instead of checking the replace flag we check directly for Set-Cookie and > do an add instead of a replace in that case. Ahhhhh... now that explains a lot. > As long as other SAPI modules ignored this incorrectly set replace flag > they should be ok with this change. My fear is that we may have some > that implemented this flag with the reverse meaning. So heads-up sapi > module maintainers, check your code! I was afraid of that. Thanks for the code review and the heads-up, Rasmus! --Cliff