Re: Patch for file.c
| From: | Stig S. Bakken | Date: | Tue, 21 May 2002 15:32:10 +0000 |
| Subject: | Re: Patch for file.c | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-84233@lists.php.net to get a copy of this message | ||
On Tue, 2002-05-21 at 17:28, Dean Richard Benson wrote:
> Hi all
>
> I have been working on a system recently that has been using the fgetcsv
> function.
>
> It works a treat except that the code "assumes" that the enclosure
> character will always be a double quote. This caused me a little bit of
> a problem as many of the csv files that I work with use the single quote
> character to achieve the same thing.
>
> I have never submitted a diff file to php before, but I have prepared
> once that adds a new optional parameter which is the enclosure character
> (defaults to double quote).
>
> Can you let me know whats the best thing to do from here to get the
> change reviewed by yourselves and possible included in the next php
> release.
>
> I wasn't sure if I could just attach my file.c.patch file to this email
> or not?
That's fine, but make sure the MIME type for the attachment is
text/plain or the mailing list software will remove it.
- Stig