Re: cvs: php4 /sapi/apache mod_php4.c

From: Date: Thu, 13 Jun 2002 22:15:04 +0000
Subject: Re: cvs: php4 /sapi/apache mod_php4.c
References: 1  Groups: php.cvs php.dev 
Request: Send a blank email to php-dev+get-85201@lists.php.net to get a copy of this message
Uh Jani, how much research did you do on this one? Don't you think there is a reason that this code is commented out? On Thu, 13 Jun 2002, Jani Taskinen wrote: > sniper Thu Jun 13 18:13:58 2002 EDT > > Modified files: > /php4/sapi/apache mod_php4.c > Log: > @- Fixed bug with Apache which let PHP_AUTH_* variables to be set when > @ external basic auth mechanism was used. (Jani) > > Fixes bugs: #16653, #14534, #14370 > > > > Index: php4/sapi/apache/mod_php4.c > diff -u php4/sapi/apache/mod_php4.c:1.132 php4/sapi/apache/mod_php4.c:1.133 > --- php4/sapi/apache/mod_php4.c:1.132 Fri May 31 00:47:15 2002 > +++ php4/sapi/apache/mod_php4.c Thu Jun 13 18:13:57 2002 > @@ -17,7 +17,7 @@ > | PHP 4.0 patches by Zeev Suraski <zeev@zend.com> | > +----------------------------------------------------------------------+ > */ > -/* $Id: mod_php4.c,v 1.132 2002/05/31 04:47:15 rvenkat Exp $ */ > +/* $Id: mod_php4.c,v 1.133 2002/06/13 22:13:57 sniper Exp $ */ > > #include "php_apache_http.h" > > @@ -403,7 +403,7 @@ > authorization = table_get(r->headers_in, "Authorization"); > } > if (authorization > -/* && !auth_type(r) */ > + && !auth_type(r) > && !strcasecmp(getword(r->pool, &authorization, ' '), > "Basic")) { > tmp = uudecode(r->pool, authorization); > SG(request_info).auth_user = getword_nulls_nc(r->pool, &tmp, ':'); > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >

« previous php.dev (#85201) next »