Re: Patch suggestions for PHP 4.2.3 (sablotron and pcre)

Hi, I applied your "less controversial" patch. I will apply it to 4.3.0-dev as well. Thanks, Edin ----- Original Message ----- From: "Troels Arvin" <troels@arvin.dk> To: <php-dev@lists.php.net> Sent: Tuesday, July 23, 2002 1:04 PM Subject: [PHP-DEV] Patch suggestions for PHP 4.2.3 (sablotron and pcre) > Hello, > > I have two patch suggestions for PHP 4.2.3. Both patches patch well into > PHP 4.2.2. > > > http://rpms.arvin.dk/php/source/patches/php-4.2.2-xslt-config.m4.pat ch > ------------------------------------------------------------------ ---- > > First part of the patch removes the iconv detection which simply doesn't > seem to work well; at least it didn't detect iconv built into glibc on my > Red Hat 7.3 system. This may be a bit controversial. > > The second part of the patch is less controversial: Without the changes, > detection of SablotSetEncoding fails on my system (I have sablotron with > javascript enabled). > > > http://rpms.arvin.dk/php/source/patches/php-4.2.2-pcre.config.m4.pat ch > ------------------------------------------------------------------ ---- > > Without this patch, configure can't find pcre.h on my system (Red Hat > 7.3) when pcre is compiled to use the system pcre library in stead of the > bundled pcre library. > > -- > Greetings from Troels Arvin, Copenhagen, Denmark > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php > > >