Re: cvs: php4 / README.PARAMETER_PARSING_API

So, should we go ahead and change it to 'long' then? The existing code would be affected of course.. On Thu, 04 Jul 2002, Yasuo Ohgaki wrote: > It sounds like changing API (int -> long) is better to me. > _zvalue_value.lval's type is long also. > > -- > Yasuo Ohgaki > > Sascha Schumann wrote: > >sas Wed Jul 3 14:36:50 2002 EDT > > > > Modified files: > > /php4 README.PARAMETER_PARSING_API > > Log: > > Please note that you need to use 'int' as a length type when > > fetching strings. > > > > > >Index: php4/README.PARAMETER_PARSING_API > >diff -u php4/README.PARAMETER_PARSING_API:1.4 > >php4/README.PARAMETER_PARSING_API:1.5 > >--- php4/README.PARAMETER_PARSING_API:1.4 Wed Jul 3 10:01:18 2002 > >+++ php4/README.PARAMETER_PARSING_API Wed Jul 3 14:36:50 2002 > >@@ -105,7 +105,14 @@ > > /* Get either a set of 3 longs or a string. */ > > long l1, l2, l3; > > char *s; > >-long length; > >+/* > >+ * The function expects a pointer to a integer in this case, not a long > >+ * or any other type. If you specify a type which is larger > >+ * than a 'int', the upper bits might not be initialized > >+ * properly, leading to random crashes on platforms like > >+ * Tru64 or Linux/Alpha. > >+ */ > >+int length; > > > > if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET, ZEND_NUM_ARGS() > > TSRMLS_CC, > > "lll", &l1, &l2, > > &l3) == SUCCESS) { > > > > > > -Andrei http://www.gravitonic.com/ <yaragn> ever seen that movie? The Matrix? <yaragn> with those green lines of flying text? <yaragn> *THAT'S* Perl