Re: libgd patch for alpha-channel mixing

On Wed, 21 Aug 2002, Tim Toohey wrote: > Any thoughts? Should I go ahead and commit this? I've never committed to PHP > before so go easy on me :-). I've been using essentially the same code on a > PHP-4.1.0 installation for a while now and I believe it works OK. Looking at your patch I see: PHP_FUNCION() { #if GD_BUNDLED ...code... #else zend_error ("does not exist"); #endif } The preferred way would be not to have these functions available at all when GD is not bundled, like: #if GD_BUNDLED PHP_FUNCTION() { } #endif (but dont forget the function entry struct then). Secondly you should use php_error_docref, and not zend_error for errormessages and finally please stick to the coding standards as used in the rest of the PHP source (well, most of it :). Derick --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --------------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net ---------------------------------------------------------------------------