Re: [PATCH] translate capitalized functions in create_stubs

inlining patch since my attachment seemed to fail... dave =========================== --- create_stubs.ORIG Tue Sep 3 13:21:41 2002 +++ create_stubs Tue Sep 3 13:33:01 2002 @@ -153,6 +153,13 @@ spec_str = spec_str "\"" +## php extension must use lower case function names. +## this will translate any capitalized letter to lowercase +## and warn the user + if (match(func_name,"[A-Z]") != 0) { + printf("NOTICE: lower casing function name '%s'\n",func_name) + func_name = tolower(func_name) + } funcs[num_funcs] = func_name types[num_funcs] = func_type maxargs[num_funcs] = args_max -----Original Message----- From: David Viner [mailto:dviner@yahoo-inc.com] Sent: Tuesday, September 03, 2002 1:43 PM To: Php-Dev@lists. php. net Subject: [PHP-DEV] [PATCH] translate capitalized functions in create_stubs Hi When we use prototype files for ext_skel, we noticed that a function name with capital letters doesn't work properly since php extension must have lowercase function names. However, ext_skel doesn't warn or fix an erroneous prototype file. Here's a small patch to the create_stubs file which will both warn users that a function name from the prototype file contains capital letters, and it will lowercase the function name. Out of curiosity, why ext_skel/create_stubs a shell/awk script? Were it written in perl, Windows users could use it too. Is there a design reason for shell/awk or is it just historical? dave