Re: RE: [PHP-CVS] cvs: php4 /ext/xml xml.c

You changed some ifdef statments by adding NETWARE for example: -#ifndef PHP_WIN32 +/*#ifndef PHP_WIN32*/ +#if !defined(PHP_WIN32) && !defined(NETWARE) Here as allways in your commits you commented out the old ifdef stament and added the new one. That is not a good idea. Simply change the ifdef stament and CVS keeps track about your changes - no need to have them inline in the code. Second thing is taht you obviously did not read the file CODING_STANDARDS well enough (Feeling guilty that i had my problems with that when i started my work here also). Most important thing you did wrong is that you used spaces for indendation instead of tabs. marcus At 15:22 06.09.2002, Ananth Kesari wrote:

Hi, I am working on porting PHP for NetWare. I am committing changes into the PHP CVS source tree from a couple of days now. James wrote to me today that I am doing something wrong during commiting. I wrote the below mail to him seeking clarifications, but the mail bounced back! Can anyone throw more light into this? Thanks in advance, Ananth.

Ananth Kesari 09/06/02 05:19PM >>>

Hi, What I am doing is that I got the latest PHP4 project from CVS. Then applied only NetWare related changes into some files within #ifdef NETWARE blocks and then committed them. I did not change any other things like header information, licences etc. Of course, I added a couple of files under NetWare folder that is being used for NetWare. So, is there anything specific that you can tell me which I am doing wrong? In fact, myself and one of my colleagues have committed some changes earlier the same way as I am doing now. Before we started to commit changes, we had gone through http://www.php.net/cvs-php.php and other related document. Is there something else we need to know? Please clarify. Thanks, Ananth.

"James Cox" <imajes@php.net> 09/06/02 04:03PM >>>

Hi, Please read PHP-CVS! You are making a large number of commits that conflict with our policies, including adding files with strange licenses and not adhering to our whitespace policy. Please do not commit again until you have addressed the concerns expressed on-list. Thanks, James -----Original Message----- From: Anantha Kesari H Y [mailto:hyanantha@novell.com] Sent: Friday, September 06, 2002 11:21 AM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php4 /ext/xml xml.c

hyanantha             Fri Sep  6 06:20:39 2002 EDT

Modified files:

    /php4/ext/xml     xml.c

Log: NetWare related changes/modifications Index: php4/ext/xml/xml.c diff -u php4/ext/xml/xml.c:1.107 php4/ext/xml/xml.c:1.108 --- php4/ext/xml/xml.c:1.107 Sat Apr 13 01:06:33 2002

+++ php4/ext/xml/xml.c        Fri Sep  6 06:20:39 2002

@@ -17,7 +17,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: xml.c,v 1.107 2002/04/13 05:06:33 mfischer Exp $ */ +/* $Id: xml.c,v 1.108 2002/09/06 10:20:39 hyanantha Exp $ */ #define IS_EXT_MODULE @@ -35,7 +35,8 @@ #if HAVE_LIBEXPAT -#ifndef PHP_WIN32 +/*#ifndef PHP_WIN32*/ +#if !defined(PHP_WIN32) && !defined(NETWARE) # include "build-defs.h" # endif # include "ext/standard/head.h" -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php