Re: cvs: php4(PHP_4_2_0) /ext/mbstring mbstring.c

Hi, Bug in POST/GET/COOKIE var handling... --enable-enc-trans user is affected. Besides, php_url_decode() was redundunt in old code. It seems this bug is introduced since values were URL decoded, but not with latest code. It's okay passing values which str not decoded, but there may be other code that rely on URL decoded values. Letting you know just in case there is such code. -- Yasuo Ohgaki Yasuo Ohgaki wrote:

yohgaki Sat Sep 7 05:26:03 2002 EDT

  Modified files:              (Branch: PHP_4_2_0)
    /php4/ext/mbstring	mbstring.c   Log:

MFH Index: php4/ext/mbstring/mbstring.c diff -u php4/ext/mbstring/mbstring.c:1.48.2.14 php4/ext/mbstring/mbstring.c:1.48.2.15 --- php4/ext/mbstring/mbstring.c:1.48.2.14 Thu Aug 1 01:47:56 2002 +++ php4/ext/mbstring/mbstring.c Sat Sep 7 05:26:03 2002 @@ -16,7 +16,7 @@

    +----------------------------------------------------------------------+

*/ -/* $Id: mbstring.c,v 1.48.2.14 2002/08/01 05:47:56 zeev Exp $ */ +/* $Id: mbstring.c,v 1.48.2.15 2002/09/07 09:26:03 yohgaki Exp $ */ /* * PHP4 Multibyte String module "mbstring" (currently only for Japanese) @@ -1030,9 +1030,9 @@ strtok_buf = NULL; var = php_strtok_r(res, separator, &strtok_buf); while (var) { + len_list[n] = php_url_decode(var, strlen(var)); val = strchr(var, '='); val_list[n] = var; - len_list[n] = php_url_decode(var, strlen(var)); n++; if (val) { /* have a value */ *val++ = '\0';