Re: cvs: php4 /ext/zlib zlib.c /main output.c

Marcus Börger wrote:

I completeley reworked my patch but haven't yet the time to finish that work since i was on a holiday trip and now moving to my new flat. I will try to look over the stuff tomorrow/this week but cannot guarantee :-( As far as i remember there was a failure in missinterpreting 'On' what should resolve to 1 and then to the default value which should be 4K. The main pronlem is that we have three parameters for either chunk size when ob works with chunked output or initial size/block size when ob works with full buffering. My new patch splits up these three parameters. Will i have the time to finish that work before php 4.3 or should i wait until 4.3 is branched? There could be many problems in the reworked

How about just fix the problem now? Just in case when you forgot, if chunk_size is 0, instead of disabling buffering, it should buffer all output so that large output can be buffered and modified afterwards. e.g. ob_start() has 0 for default chunk size. -- Yasuo Ohgaki