Re: Re: cvs: php4 /main output.c

At 12:13 03/10/2002, Yasuo Ohgaki wrote:

Sebastian Bergmann wrote:

Zeev Suraski wrote:

That's the desired behavior, please make sure you did not deviate from it.

He deviated from it. Functions like highlight_string() or var_export() currently don't work with implicit_flush enabled.

Guys, implicit flush feature is broken for a looonng time. Please refer to my comment recently added to output.c

But it does not seem as if you fixed it properly. I don't see how implicit flush can be at all related to output buffering. If it was, it should have been trivial to fix it, at a centralized place. You appear to be adding code all over the codebase, and as far as I understood from the thread, apparently you also made implicit flush disable output buffers, which is completely undesired behavior. Please revert! If there's still an issue with implicit flush after you revert, I will fix it. Thanks, Zeev