Re: Re: cvs: php4 /ext/session session.c

Please use sizeof("sid") and not 4 in such code. Also, why use hash_find() if just calling hash_del() would work? Andi At 12:05 AM 9/27/2002 +0200, Markus Fischer wrote:

    Guys,

    _Please_ include bug fixes in NEWS entries (or separately
    commit them) so we've complete log.

    Browsing back the ChangeLog and finding missing treasures
    ain't that funny.

    ;)

    thanks,

        - Markus

On Thu, Sep 26, 2002 at 06:12:27PM -0000, Ilia Alshanetsky wrote :

iliaa         Thu Sep 26 14:12:27 2002 EDT

Modified files:

    /php4/ext/session session.c

Log: Fixed bug #11643 Index: php4/ext/session/session.c diff -u php4/ext/session/session.c:1.317 php4/ext/session/session.c:1.318 --- php4/ext/session/session.c:1.317 Thu Sep 26 12:46:21 2002

+++ php4/ext/session/session.c        Thu Sep 26 14:12:27 2002

@@ -17,7 +17,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: session.c,v 1.317 2002/09/26 16:46:21 sniper Exp $ */ +/* $Id: session.c,v 1.318 2002/09/26 18:12:27 iliaa Exp $ */ #ifdef HAVE_CONFIG_H #include "config.h" @@ -826,6 +826,7 @@

      int module_number = PS(module_number);
      int nrand;
      int lensess;
+     zend_constant *c;

      PS(apply_trans_sid) = PS(use_trans_sid);

@@ -919,7 +920,11 @@

              php_session_send_cookie(TSRMLS_C);
      }

-

+     /* check if SID constant exists, if it does destroy it. */
+     if (zend_hash_find(EG(zend_constants), "sid", 4, (void **) &c) != FAILURE) {
+             zend_hash_del(EG(zend_constants), "sid", 4);
+     }

+

      if (define_sid) {
              smart_str var = {0};

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc <rei_> Derick, while ($xml) $ass->get_new_ideas(); <[James]> Markus: IE on_user_fart()???? -- People doesn't seem to like the new XHTML2 specs :) -- -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php