Re: [PATCH] .phps support for Apache 2
| From: | Andi Gutmans | Date: | Sun, 06 Oct 2002 20:15:59 +0000 |
| Subject: | Re: [PATCH] .phps support for Apache 2 | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-89100@lists.php.net to get a copy of this message | ||
ctx->r->handler[strlen("application/x-httpd-php")]
Is this actually the way it's supposed to work? (based on the length)? Unless there's something I'm missing I'd prefer to see an strcmp() here. It might be a bit slower but it's definitely more robust for future changes.
Andi
At 12:06 PM 10/4/2002 -0400, Ilia A. wrote:
The attached patch adds .phps file support for Apache 2, allowing Apache 2 users to show prettified source of their scripts, just like their Apache 1 counterparts can. It is a fairly simple patch, that adds just 2 cmp overhead for this functionality, so its not too bad imho. Please review the patch and let me know if there are any objections to it's addition. Ilia -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php