Re: Anyone confirm this?
| From: | Wez Furlong | Date: | Mon, 07 Oct 2002 14:20:02 +0000 |
| Subject: | Re: Anyone confirm this? | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-89161@lists.php.net to get a copy of this message | ||
It seems quite likely that this change should be made; it doesn't
make sense to check for a hex-digit twice on the same character in
the same if statement, and quoted printable uses "=XX", where XX is two
hex digits, as a substitution for a character whose ascii code is XX.
--Wez.
On 10/07/02, "Dan Kalowsky" <dank@deadmime.org> wrote:
> Begin forwarded message:
>
> > From: mclap@simpage.mv.ru
> > Date: Mon Oct 7, 2002 8:24:14 AM US/Eastern
> > To: php-bugs@lists.php.net
> > Subject: #19798 [NEW]: mistype in source
> >
> > From: mclap@simpage.mv.ru
> > Operating system: any
> > PHP version: 4.2.3
> > PHP Bug Type: Unknown/Other Function
> > Bug description: mistype in source
> >
> > php-4.2.3/ext/standard/quot_print.c
> > ---
> > while ( str_in[i] )
> > {
> > switch (str_in[i])
> > {
> > case '=':
> > if (str_in[i+1] && str_in[i+2] &&
> > isxdigit((int)str_in[i+1]) &&
> > isxdigit((int)str_in[i+1]) )
> > {
> > str_out[j++] = (php_hex2int((int)str_in[i+1]) << 4 )
> > + php_hex2int((int)str_in[i+2]);
> > i += 3;
> > }
> > ---
> >
> > may be lines above must looking like:
> > ---
> > if (str_in[i+1] && str_in[i+2] &&
> > isxdigit((int)str_in[i+1]) &&
> > isxdigit((int)str_in[i+2]) )
> > ---
> > ???