Re: Re: cvs: php4 /ext/standard array.c

From the feedback I think it's best to revert this. Please do so. Thanks, Andi At 11:05 PM 10/9/2002 +0200, Andi Gutmans wrote:

At 11:03 PM 10/9/2002 +0200, Sterling Hughes wrote:

On Wed, 2002-10-09 at 22:56, Derick Rethans wrote:

On Wed, 9 Oct 2002, Andi Gutmans wrote:

At 10:35 PM 10/9/2002 +0200, Sterling Hughes wrote:

On Wed, 2002-10-09 at 22:21, Thies C. Arntzen wrote:

On Wed, Oct 09, 2002 at 06:29:45PM -0000, Sterling Hughes wrote:

sterling            Wed Oct  9 14:29:45 2002 EDT

Modified files:

    /php4/ext/standard      array.c

Log: clean these functions up using zend_parse_parameters and

nuke the

use of

HASH_OF() which is inappropriate in these cases...

    will prev still work on objects after your patch?

none of them do - none of them should either - why would you want to access an object like you would an _indexed_ array? -Sterling

You might want to traverse all of the members of an object. I find it worrying that people break BC whenever they feel like it and without consulting php-dev@ first. I think we should make a rule that BC should not be broken unless discussed on php-dev.

I have to agree about that...

I take that back, you could use key(), I guess, but there are certainly better ways to do that. Its not exactly breaking bc if its undocumented and widely unused. Php-dev and Php-cvs are not all users, but it does give a good "experience base" of people who have programmed php regularly and in-depth. Look at the proto of the function, its been that way for awhile, its been made clear that reset(), next() and prev() are meant for arrays. My guess is that this is legacy code (from what i can tell most php3 code was written using the HASH_OF macro), but it was not intended to be this way. I wasn't wantonly breaking bc, as you can see even the function prototypes show that it was meant to be used with an array, so i kept it consistent with the documentation and prototypes, and what I considered to be reasonable leeway, i'll gladly change it back if that's the general concensus here though (I would like to hear that at least one person has actually used this though.)

I haven't :) Anyway, I understand your reasoning. I just felt that lately too many things have been breaking around us. I'm cc'ing php-dev as that is a bigger forum. Have any of you guys used these functions on objects? Do you think people use them? Personally I agree that they shouldn't work but I'm just worried about breaking BC. Andi -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php