RE: [PHP-DEV] Re: Apache 2 & incorrect 304 response to "If-Modified-Since"
| From: | James Cox | Date: | Tue, 15 Oct 2002 00:48:58 +0000 |
| Subject: | RE: [PHP-DEV] Re: Apache 2 & incorrect 304 response to "If-Modified-Since" | ||
| References: | 1 | Groups: | php.dev php.install |
| Request: | Send a blank email to php-dev+get-89463@lists.php.net to get a copy of this message | ||
I don't particularly like the look of this patch... we should fix 304's
properly...
> >
> > --- sapi/apache2filter/sapi_apache2.c~ Fri Aug 16 07:27:03 2002
> > +++ sapi/apache2filter/sapi_apache2.c Mon Oct 14 23:27:26 2002
> > @@ -558,14 +558,24 @@
> > return OK;
> > }
> >
> > +static int includes_setup(ap_filter_t *f)
> > +{
> > + /* We will ALWAYS set the no_local_copy value to 1 so
> > + * that we will not send 304s.
> > + */
> > + f->r->no_local_copy = 1;
> > +
> > + return OK;
> > +}
> > +
> > static void php_register_hook(apr_pool_t *p)
> > {
> > ap_hook_pre_config(php_pre_config, NULL, NULL, APR_HOOK_MIDDLE);
> > ap_hook_post_config(php_apache_server_startup, NULL,
> NULL, APR_HOOK_MIDDLE);
> > ap_hook_insert_filter(php_insert_filter, NULL, NULL,
> APR_HOOK_MIDDLE);
> > ap_hook_post_read_request(php_post_read_request, NULL,
> NULL, APR_HOOK_MIDDLE);
> > - ap_register_output_filter("PHP", php_output_filter,
> NULL, AP_FTYPE_RESOURCE);
> > - ap_register_input_filter("PHP", php_input_filter, NULL,
> AP_FTYPE_RESOURCE);
> > + ap_register_output_filter("PHP", php_output_filter,
> includes_setup, AP_FTYPE_RESOURCE);
> > + ap_register_input_filter("PHP", php_input_filter,
> includes_setup, AP_FTYPE_RESOURCE);
> > }
> >
> > AP_MODULE_DECLARE_DATA module php4_module = {
> >
>
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>