Re: cvs: php4 /ext/standard info.c

> Why did you remove the charset info? > > I want my charset back since it enables correct handling of the output. > Everything these lines commented out by you do is telling the receiver > what charset he gets. That is compareable to http charset info which > will be generated by those modules also. This way you can enable > mbsting or iconv with any charset you like. > > This has nothing to do with the other thing you did in this patch: > changing behaviour of php_escape_html_entities(). I guess you did > not understand what you removed? No, I do understand what I did. Every browser I tested displayed the phpinfo() page correctly when the charset was not specified ... i.e., they guessed the right charset. If you explicitly specify a charset, then you need to encode the characters according to that character set. The problem is, that encodings such as é and Ä (which show up on the credits page), don't work under all charsets/encodings. I will test it again, with the charset declaration back in, but I'm relying on people with non-Western browsers and charsets for some feedback on how the choice of charset affects the rendering of the pages. - Colin