Re: ftok and weird ifdefs

On Sat, 19 Oct 2002, Andrew Sitnikov wrote: > Hello Derick, > > > DR> I was checking some test result output, and while doing that I found > DR> that ftok is only defined while this preprocessor macro evalutates to > DR> true: > DR> #if HAVE_SYSVSEM || HAVE_SYSVSHM || HAVE_SHMOP > DR> Can you tell me why this is needed? > DR> It is in both in: > DR> ext/standard/basic_functions.c (line 834) > DR> ext/standard/ftok.c (line 23) > DR> ext/standard/php_ftok.h (line 24) > > I thought that this function only needed when we have one ext from > IPC (sysvsem,sysvshm,shmop), but may be i am mistaken ... Well, AFAIK we only use #ifdefs for OS and system specific things. It doesn't make much sense to me to disable this function because 'you only need it when extension foo is enabled'. Do you mind if I remove these ifdefs? regards, Derick -- --------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-