Re: cvs: php4 / Makefile.global

Derick this is nonsense!!!!! We developers can use php -c bla run-tests.php xyz But make is for automated things and for those not reading README.TESTING where everything should be explained. The typical user who is just glad to be able to build his private distribution of php will just call 'make test' to check that the created php executable works. After doing some ini settings many tests will fail.... In contrast when you want complex tests just use --INI-- section to test different ini values. Even better would be to use this --INI-- section where ever a special value is needed. Remeber the tests are not made to test your ini file but for testing the general functionality of PHP. And this should of cause not be affected by some private ini settings. So please readd the ini to make test and use commandline when you want to test other ini files. marcus At 10:46 23.10.2002, Derick Rethans wrote:

derick          Wed Oct 23 04:46:50 2002 EDT

Modified files:

    /php4       Makefile.global

Log: - Remove this messed up thing AGAIN #- Yasuo: touch it and I'll fly over applying a YART on you. Index: php4/Makefile.global diff -u php4/Makefile.global:1.34 php4/Makefile.global:1.35 --- php4/Makefile.global:1.34 Tue Oct 22 21:21:04 2002

+++ php4/Makefile.global        Wed Oct 23 04:46:49 2002

@@ -49,7 +49,7 @@ test: $(SAPI_CLI_PATH)

        @TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \
        TEST_PHP_SRCDIR=$(top_srcdir) \
-                       $(top_builddir)/$(SAPI_CLI_PATH) -c $(top_srcdir)/php.ini-dist $(top_srcdir)/run-tests.php $(TESTS)
+                       $(top_builddir)/$(SAPI_CLI_PATH) $(top_srcdir)/run-tests.php $(TESTS)

clean:

        find . -name \*.lo -o -name \*.o | xargs rm -f

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php