Re: cvs: php4 / run-tests.php

I haven't installed xslt yet so i do not know...but i am testing with 25% of the modules and get the feeling that we must check for all warnings and errors. A special situation is ext/session/tests/008-php4.2.3.phpt where a warning mechanism is checked..here the following would be enough --EXPECTF-- %s(%d) : Warning - Your %s But perhaps it would be a better solution to automatically add <?php echo $error_msg; ?> at the end of each FILE section and set track_errors=1, display_errors=0, log_errors=0. At 21:41 25.10.2002, Melvyn Sopacua wrote:

At 21:27 25-10-2002, Marcus Börger wrote:

It should not break any test...please send a list of those failed.

ext/xslt/xslt-001.phpt (used to be 009.phpt). log_errors=1 on cli, is /dev/stderr. Ilia: Could you take a look at the message I sent regarding your fix of that test? There are other problems with memory leaks (display_memleak and --disable-debug), so I'm enclined to drop this test - the format of the error message is not important and not what we we're testing. I've wrapped the procedure that caused the memleak in the first place into a macro, and used that. Any future places this should occur, we'll use the macro.

marcus At 19:24 25.10.2002, Ilia Alshanetsky wrote:

iliaa           Fri Oct 25 13:24:10 2002 EDT

Modified files:

    /php4       run-tests.php

Log: The log_errors=1 breaks a number of tests and is useless for our purposes, removing. Index: php4/run-tests.php diff -u php4/run-tests.php:1.89 php4/run-tests.php:1.90

--- php4/run-tests.php:1.89     Thu Oct 24 14:14:39 2002

+++ php4/run-tests.php Fri Oct 25 13:24:09 2002 @@ -484,7 +484,7 @@

                "-d 'disable_functions='",
                "-d 'error_reporting=2047'",
                "-d 'display_errors=0'",
-               "-d 'log_errors=1'",
+               "-d 'log_errors=0'",
                "-d 'html_errors=0'",
                "-d 'docref_root=/phpmanual/'",
                "-d 'docref_ext=.html'",

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua