RE: [PHP-DEV] php/ext/xslt and TSRM

At 10:08 AM 10/30/2002 -0800, Rasmus Lerdorf wrote:

Well, in the threaded case you avoid a rather expensive ts_resource_ex() function call, so what you gain is performance. Functionality should be the same.

It's not *that* slow as on most OS's we cache it in local storage. But then again, yes, it is definitely advised to pass it around and to TSRMLS_FETCH() as little as possible but there are some cases which would mean passing them around too much just to reach some upper function where it's not worth the hassle especially if the function is slow anyway.

-Rasmus On Wed, 30 Oct 2002, David Viner wrote: perhaps i'm a bit slow... what is the gain by moving the TSRMLS_FETCH() from functions to having the TSRM params in the php_xslt struct? that is, what functionality or benefit is brought to the extension or the code? Is there something that the extension does not handle properly as it stands? or is the idea simply to remove lots of TSRMLS_FETCH() calls? btw - we should move this discussion from php-dev to sab-php. that's where we're trying to maintain all php/sablotron maintanence issues. dave -----Original Message----- From: Marcus Boerger [mailto:marcus.boerger@t-online.de] Sent: Wednesday, October 30, 2002 7:38 AM To: Melvyn Sopacua Cc: Sterling Hughes; php-dev@lists.php.net; David Viner Subject: Re: [PHP-DEV] php/ext/xslt and TSRM At 15:54 30.10.2002, Melvyn Sopacua wrote:

At 15:10 30-10-2002, Marcus Boerger wrote:

What about removing all TSRMLS_FETCH() and instead passing TSRM parameters in php_xslt struct?

Before you do that, I'd rather you wait untill after the weekend - unless there's a compelling reason not too. I'm working on exposure of Sablotron SXP_ functions, and this may alter quite a few things in the files. A complete overhaul of the thread issues is then welcome, but I think

David

is capable of this also.

When it shall be done by me tell me when i can proceed. I suggest a diff to check before comitting would be the way to go with this issue. marcus

With kind regards, Melvyn Sopacua <?php include("not_reflecting_employers_views.txt"); ?>

-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php