Re: [PATCH] ereg to pcre conversion

On Fri, 1 Nov 2002, Sander Roobol wrote: >On Thu, Oct 31, 2002 at 02:47:27PM -0500, Ilia A. wrote: >> I would like to propose that we drop the old ereg library and use only >> a single regular expression library, PCRE. For BC purposes I've written a >> patch (see attached file), which emulates the old ereg_* functions for people >> who still rely on those, using PCRE. > >We probably have to make a bunch of tests to see if we don't break BC >with this patch. If we don't break BC, and only then, I would give +1 on >this patch. Too many people rely on the ereg_* functions, so IMO we >really can't afford changing any behaviour. IMO if some behaviour of ereg_* is simply wrong, and this change "fixes" it, it's acceptable 'breaking of BC'. :) --Jani