Re: TSRM & compiler warnings

Commited. Thanks. Andi At 02:04 PM 11/5/2002 +0100, Marcus Boerger wrote:

Could someone with karma please commit following patch or give me karma for tsrm? It would silence all those warnings at once: /usr/src/php4-HEAD/TSRM/TSRM.c: In function `tsrm_startup': /usr/src/php4-HEAD/TSRM/TSRM.c:124: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:124: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c:132: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:132: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c:142: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:142: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:142: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:142: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c: In function `tsrm_shutdown': /usr/src/php4-HEAD/TSRM/TSRM.c:177: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:177: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c: In function `ts_allocate_id': /usr/src/php4-HEAD/TSRM/TSRM.c:196: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:196: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:196: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c:202: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:202: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:202: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c:209: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:209: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c:241: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:241: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:241: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c: In function `allocate_new_resource': /usr/src/php4-HEAD/TSRM/TSRM.c:250: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:250: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:250: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c: In function `ts_resource_ex': /usr/src/php4-HEAD/TSRM/TSRM.c:311: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:311: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:311: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:311: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c:323: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:323: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:323: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:323: warning: statement with no effect /usr/src/php4-HEAD/TSRM/TSRM.c: In function `tsrm_mutex_lock': /usr/src/php4-HEAD/TSRM/TSRM.c:511: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:511: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c: In function `tsrm_mutex_unlock': /usr/src/php4-HEAD/TSRM/TSRM.c:538: warning: left-hand operand of comma expression has no effect /usr/src/php4-HEAD/TSRM/TSRM.c:538: warning: left-hand operand of comma expression has no effect cvs -z3 -q diff TSRM.c (in directory S:\php4-HEAD\TSRM\) Index: TSRM.c =================================================================== RCS file: /repository/TSRM/TSRM.c,v retrieving revision 1.46 diff -u -r1.46 TSRM.c

--- TSRM.c      5 Oct 2002 11:34:02 -0000       1.46
+++ TSRM.c      5 Nov 2002 13:01:41 -0000

@@ -79,7 +79,7 @@

                } \
        }

#else -#define TSRM_ERROR +#define TSRM_ERROR(args)

 #define TSRM_SAFE_RETURN_RSRC(array, offset, range)            \
        if (offset==0) {                                                                        \
                return &array;                                                                  \