Re: Return -1

On Sat, 9 Nov 2002, Maxim Maletsky wrote: > I have just fixed a few doc files where it was stating that a function > returned -1 but the sources had clear RETURN_FALSE. > > Done that, I took some time to grep my phpdoc and php4 trees for -1 > returns and, surprisingly, I found out that there were a few suspicious places > where -1 could be better changed to RETURN_FALSE. > > Some of such places were FTP, pgSQL, LDAP functions. Maybe a dozen or > less in total. > > I don't think this should be done right now, as we would directly break > the backwards compatibility. But, shouldn't we be considering such > consistency changes for PHP5 releases? > > My point is that functions behaviour consistency can be very important > for many users, and breaking just a few lines of PHP4 code since first > PHP5 releases would probably be a small price to pay. I don't see any reason why we should break it and give users more headaches. Sure, consistency is nice, but IMO not worth it to break BC. Derick -- --------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-