Re: reg.c warning patch
| From: | Maxim Maletsky | Date: | Thu, 14 Nov 2002 01:55:45 +0000 |
| Subject: | Re: reg.c warning patch | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-91000@lists.php.net to get a copy of this message | ||
Alright - no attachments on the list :)
here it is inline:
--- F:\CVS\PHP.NET\php4\ext\standard\reg2.c 2002-11-14 02:31:11.000000000 +0100
+++ F:\CVS\PHP.NET\php4\ext\standard\reg.c 2002-11-14 01:53:56.000000000 +0100
@@ -365,7 +365,7 @@
walkbuf = &buf[tmp + subs[0].rm_so];
walk = replace;
while (*walk)
- if ('\\' == *walk && isdigit(walk[1]) && walk[1] - '0'
<= re.re_nsub) {
+ if ('\\' == *walk && isdigit(walk[1]) && walk[1] - '0'
<=((char) re.re_nsub)) {
if (subs[walk[1] - '0'].rm_so > -1 && subs[walk[1] - '0'].rm_eo
> -1
/* this next case shouldn't happen. it does. */
&& subs[walk[1] - '0'].rm_so <= subs[walk[1] - '0'].rm_eo) {
--
Maxim Maletsky
maxim@php.net
On Thu, 14 Nov 2002 02:49:06 +0100 Maxim Maletsky <maxim@php.net> wrote:
>
> I've patched a tiny "signed/unsigned mismatch" warning in
> ext/standard/reg.c. I based on what a similar line (343) was doing.
>
> Someone with karma double-check and commit.
>
>
>
>
> --
> Maxim Maletsky
> maxim@php.net
>