Re: Re: #19259 [Csd->Ctl]: sort-functions don't work
| From: | (Marcus Börger) | Date: | Sat, 16 Nov 2002 19:29:58 +0000 |
| Subject: | Re: Re: #19259 [Csd->Ctl]: sort-functions don't work | ||
| References: | 1 2 3 4 5 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-91144@lists.php.net to get a copy of this message | ||
Could you try the following patch instead?
cvs -z3 -q diff 008.phpt (in directory S:\php4-HEAD\ext\standard\tests\general_functions)
Index: 008.phpt
===================================================================
RCS file: /repository/php4/ext/standard/tests/general_functions/008.phpt,v
retrieving revision 1.1
diff -u -r1.1 008.phpt
--- 008.phpt 21 Aug 2002 01:27:56 -0000 1.1 +++ 008.phpt 16 Nov 2002 19:29:06 -0000@@ -5,7 +5,7 @@ --FILE-- <?php // this checks f,g,G conversion for snprintf/spprintf -var_dump(array(ini_get('precision'),.012,-.012,.12,-.12,1.2,-1.2,12.,-12.,0..000123,.0000123,123456789012,1234567890123,12345678901234567890)); +var_dump(array(ini_get('precision'),.012,-.012,.12,-.12,1.2,-1.2,12.,-12.,0..000123,.0000123,123456789012.0,1234567890123.0,12345678901234567890)); ?> --EXPECT-- array(14) { At 20:17 16.11.2002, Michael Mauch wrote:
Marcus Börger <marcus.boerger@t-online.de> wrote: Thanks it looks good - applied. Thanks, great. While we're at it, there's another test which fails on 64 bit machines and can easily be fixed: var_dump float test [ext/standard/tests/general_functions/008.phpt] This test fails because 123456789012 and 1234567890120 are PHP integers on 64 bit machines: ---- EXPECTED OUTPUT [...] [11]=> float(123456789012) [12]=> float(1234567890120) ---- ACTUAL OUTPUT [...] [11]=> int(123456789012) [12]=> int(1234567890123) The fix:--- ext/standard/tests/general_functions/008.phpt~ Wed Aug 21 03:27:56 2002 +++ ext/standard/tests/general_functions/008.phpt Sun Nov 10 22:50:29 2002@@ -5,7 +5,7 @@ --FILE-- <?php // this checks f,g,G conversion for snprintf/spprintf -var_dump(array(ini_get('precision'),.012,-.012,.12,-.12,1.2,-1.2,12.,-12.,0.000123,.0000123,123456789012,1234567890123,12345678901234567890)); +var_dump(array(ini_get('precision'),.012,-.012,.12,-.12,1.2,-1.2,12.,-12.,0.000123,.0000123,123456789012,(float)1234567890123,(float)12345678901234567890)); ?> --EXPECT-- array(14) { Regards...Michael-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php