Re: [PATH] update to earlier proposed patch for getanyrr() function addition

On Sun, 17 Nov 2002, Marcus Börger wrote: > I guessed we'd have to look into ext/standard/config.m4 > for that new functionality. Ah, of course. Derick > > At 16:19 17.11.2002, Derick Rethans wrote: > >On Sun, 17 Nov 2002, Marcus Börger wrote: > > > > > Sure but anyway we would need to review the > > > config file if everything we need is in place. > > > >uhm, what config file? > > > > > >Derick > > > > > At 14:54 17.11.2002, Derick Rethans wrote: > > > >On Sun, 17 Nov 2002, Marcus Börger wrote: > > > > > > > > > I could do the autoconf stuff and i vould go for naming all > > > > > these function dns_get_xx() and such. > > > > > > > >nice, but I dont think we need to introduce (about) 10 functions > > > >which do basically the same thing except for returning a different > > > >record. What I meant was something like this: > > > > > > > >dns_get_record("php.net", DNS_MX); > > > > > > > >and of course having all the other DNS_* records defined as constant in > > > >PHP. We can then also wrap the original getmxrr() function to use this > > > >new function. > > > > > > > >Derick > > > > > > > > > At 12:38 17.11.2002, Derick Rethans wrote: > > > > > >On Sun, 17 Nov 2002 nicos@php.net wrote: > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > Who can commit that now? > > > > > > > > > > > >I don't think it's ready yet. I agree with Marcus that the > > > > > >name of the > > > > > >function should be different then getanyrr(), it definitely > > doesn't fit > > > > > >into the naming things we have (with that getmxrr() doesn't fit > > either). > > > > > > > > > > > >I also think that the selection of the type of record to fetch > > should be > > > > > >made a constant so that we don't need to strncasecmp it everytime, > > > > > > > > and I > > > > > >would favor an implementation with zend_parse_parameters() to get > > rid of > > > > > >the (IMO) ugly parameter handling. > > > > > > > > > > > >Also, a lot of lines don't follow coding standards, like: > > > > > >n = > > > > > >res_nmkquery(&res,QUERY,Z_STRVAL_P(host),C_IN,type_to_fetch,NULL,0, > > > > > > > > NULL > > > > ,buf..qb2,sizeof > > > > > >buf); > > > > > > > > > > > >instead of: > > > > > >n = res_nmkquery(&res, QUERY, Z_STRVAL_P(host), C_IN, > > > > > >type_to_fetch, > > > > NULL, > > > > > >0, NULL, buf.qb2, sizeof(buf)); > > > > > > > > > > > >And I miss autoconf checks for all those DNS functions (like > > > > > >res_mkquery, dn_expand) which might not exist on all platforms. > > > > > > > > > > > >regards, > > > > > >Derick > > > > > > > > > > > > > "Marcus Börger" <marcus.boerger@t-online.de> a > > > > > > > écrit dans le > > message de > > > > > > > news: > > > > > > > 5.1.0.14.2.20021117011641.01fd4fd0@pop.t-online.de... > > > > > > > > Function is nice but the function name is not. > > > > > > > > Attached is a second revised patch that fixes the build > > > > > > > > problems. > > > > > > > > > > > > > > > > marcus > > > > > > > > > > > > > > > > At 00:11 17.11.2002, Pollita wrote: > > > > > > > > >Per corrections suggested by nicos@php.net, attached is > > > > > > > > >a > > > > revised pacth > > > > > > > to > > > > > > > > >ext/standard/dns.c for addition of getanyrr() function. > > > > > > > > > > > > > > > > > > > > > > > > > > >-- > > > > > > > > >PHP Development Mailing List > > > > > > > > ><http://www.php.net/> > > > > > > > > >To unsubscribe, visit: > > > > > > > > >http://www.php.net/unsub.php > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > PHP Development Mailing List > > > > > > > <http://www.php.net/> > > > > > > > To unsubscribe, visit: > > > > > > > http://www.php.net/unsub.php > > > > > > > > > > > > > > > > > > >-- > > > > > > > > > > > >------------------------------------------------------------------- > > ---- > > > > ---- > > > > > > Derick > > > > Rethans > > > > http://derickrethans.nl/ > > > > > > JDI Media Solutions > > > > > >--------------[ if you hold a unix shell to your ear, do you hear the > > > > c? ]- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >-- > > > > > >PHP Development Mailing List > > > > > ><http://www.php.net/> > > > > > >To unsubscribe, visit: > > > > > >http://www.php.net/unsub.php > > > > > > > > > > > > > > > > > >-- > > > > > > > >----------------------------------------------------------------------- > > ---- > > > > Derick > > Rethans B߯�� > > ���\�sY�http://derickrethans.nl/ > > > > JDI Media Solutions > > > >--------------[ if you hold a unix shell to your ear, do you hear the > > c? ]- > > > > > > > > > >-- > > > >--------------------------------------------------------------------------- > > Derick Rethans > > http://derickrethans.nl/ > > JDI Media Solutions > >--------------[ if you hold a unix shell to your ear, do you hear the c? ]- > > -- --------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-