Re: need directions adding a func.

On Thu, 21 Nov 2002, Maxim Maletsky wrote: > I've added an OCI8 function in CVS the other week. I've avoided its > release in RC1 so I can test it well, but it seems to be pretty stable > and can be released with RC2. We dont put new functions in a release after we branched to make sure we don't introduce new bugs with functions. > Since I never had to do this yet, I wanted to know a few things before I > mess up something: > > 1. How do I get it onto ChangeLog? Normally, I would commit it with > "@ my Message" to have it in NEWS, but I heard it is broken. What should > I do? It went to ChangeLog automatically, and you should indeed just use @- before your commit message. > 2. Is there anything I should be aware of before tagging current oci8.c > for RC2? Will all CVS be tagged for RC2 or is it left up to maintainers? It wont be in RC2, as you didn't commit the function to the branch; and it should not be in the branch for PHP_4_3. > 3. How would I go about adding the docs for the function? checkout the phpdoc module and just put a new .xml file in the en/reference/oci8 directory. > The function I refer to is OCIPasswordChange(). It allows you to handle > expired Oracle users. OCIPasswordChange() is strictly based on Oracle > internal permissions and directly aliases OCI. It was in TODO list for > quite long time. > > I've been also considering disallowing this function in safe mode for > security reasons. Opinions? I think it should be disabled in safe_mode indeed. > (Thies disappeared somewhere. Anyone heard from him?) He is at ApacheCon in las Vegas, might be just too busy. Derick -- --------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-