Re: [PATCH] Changes to ext_skel for C++

How about adding something like this to skeleton.c: /* __begin_extern_c__ */ /* __end_extern_c__ */ And having the sed script in ext_skel replace them with the proper extern "C" stuff? That way there's no need for skeleton.cpp and just a few changes need to be made in skeleton.c. J Sascha Schumann wrote: > On Fri, 29 Nov 2002, J Smith wrote: > >> >> Attached is a patch to ext_skel that adds an optional argument (--cpp) >> that will create a PHP extension in C++ rather than C. Also attached is >> skeleton.cpp, which basically mirrors ext/skeleton/skeleton.c with a few >> modifications for using C++. I could've just made some changes to >> skeleton.c and done some sed work in the ext_skel script, but I think >> it's clearer to have them separated into two files. > > I'm reluctant to duplicate the contents of the .c file for > maintenance reason. Cannot you just put the C++ specific > code into a > > /* Remove this part, if this is not a C++ extension */ > #ifdef __cplusplus > > #endif > > section? > > - Sascha