Re: Re: cvs: php4 /sapi/cli php_cli.c

From:	Andi Gutmans	Date:	Thu, 19 Dec 2002 21:51:47 +0000
Subject:	Re: Re: cvs: php4 /sapi/cli php_cli.c
References:	1 2 3 4	Groups:	php.dev
Request:	Send a blank email to php-dev+get-92697@lists.php.net to get a copy of this message

At 01:28 PM 12/19/2002 +0000, Wez Furlong wrote:

Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request shutdown?

If these are per-request constants then you are correct and the patch was OK. I thought these were constants which survive requests. Andi

--Wez. On Wed, 18 Dec 2002, Andi Gutmans wrote: I don't like these voodoo patches. I think if the stream is destroyed twice that should be solved and not the constant itself. Unless you have a good reason please revert your patch and talk to Wez about fixing this properly. Thanks, Andi
-       ic.flags = CONST_CS | CONST_PERSISTENT;
+       ic.flags = CONST_CS;