Re: [PATCH]apache_register_shutdown_function final version

From: Date: Mon, 30 Dec 2002 17:54:58 +0000
Subject: Re: [PATCH]apache_register_shutdown_function final version
References: 1  Groups: php.dev 
Request: Send a blank email to php-dev+get-92980@lists.php.net to get a copy of this message
That's a bit of an odd way to implement it - are you sure closing the link explicitly at that point won't interfere with anything? In 4.1 (or whatever the last version it worked like that was), it was taking advantage of the fact PHP's resource pool was being destroyed after the link was already closed. It sounds a bit risky to me to close the link explicitly at this point, even though I'm not currently aware of any immediate problem this may cause (maybe it would ruin keep-alive?) Zeev At 19:22 30/12/2002, Joseph Tate wrote:
As a reminder, this replaces the register_shutdown_function functionality removed in 4.1.x as described at http://bugs.php.net/15209. I've made my final adjustments to the patch. Please review and commit both to HEAD and PHP_4_3. I received no response from the SAPI guru's, so I went ahead and added the sapi_close function to all SAPI modules, initializing it to NULL. It's not implemented for anything but apache 1.3. Implementing for Apache2 is not a big deal, just call ap_lingering_close from within sapi_close. With the addition of sapi_close, it should be possible to add the functionality of apache_register_shutdown_function to every platform implementing the sapi_close method. Also, those on non-Apache systems, please test to make sure that this does not break your builds. Thanks, Joseph jtate@php.net


« previous php.dev (#92980) next »