Re: Patch for #21330 - socket_select()
| From: | Tularis | Date: | Thu, 02 Jan 2003 13:16:24 +0000 |
| Subject: | Re: Patch for #21330 - socket_select() | ||
| References: | 1 2 3 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-93045@lists.php.net to get a copy of this message | ||
nicos@php.net wrote:
Well it was attached it looks the mailing list is dening them. It put it online: http://nicos.worldakt.com/socket_select.patch Regards. M.CHAILLAN Nicolas nicos@php.net www.WorldAKT.com Hébergement de sites internets.I know this doesn't really belong here, but, I always like to keep my code as small as possible, do I think you should change: if (sec != NULL || sec != 0) {
convert_to_long_ex(&sec);
tv.tv_sec = Z_LVAL_P(sec);
tv.tv_usec = usec;
tv_p = &tv;
}
else {
tv.tv_sec = 0;
tv.tv_usec = 0;
tv_p = &tv;
}
to:
if (sec != NULL || sec != 0) {
convert_to_long_ex(&sec);
tv.tv_sec = Z_LVAL_P(sec);
tv.tv_usec = usec;
} else {
tv.tv_sec = 0;
tv.tv_usec = 0;
}
tv_p = &tv;
But, as I said it's just a fashion statement, and nothing important... let stand that it will make *any* difference ;)