Re: Patch for #21309 - memory + php_error_docref.
| From: | nicos@php.net | Date: | Fri, 03 Jan 2003 10:08:00 +0000 |
| Subject: | Re: Patch for #21309 - memory + php_error_docref. | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-93065@lists.php.net to get a copy of this message | ||
Okay, but can you just copy the file, apply the patch and read it then... To
see if i've not forgotten something (even if I worked hard on it).
--
Regards.
M.CHAILLAN Nicolas
nicos@php.net
www.WorldAKT.com Hébergement de sites internets.
"Derick Rethans" <derick@php.net> a écrit dans le message de news:
Pine.LNX.4.44.0301031013510.17721-100000@jdi.jdimedia.nl...
> On Fri, 3 Jan 2003 nicos@php.net wrote:
>
> > Hello,
> >
> > Even if this bug was assigned to sesser, this is a patch that fix
the
> > memory managment and that removes perror and replace it by
> > php_error_docref().
>
> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "ftp_open:
cannot get socket name");
>
> No need to repeat the ftp_open, this is php_error_docref's
> task:
> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Cannot get socket name");
>
>
> >
> > It's also online if the mailing is denying it:
> > http://nicos.worldakt.com/ftp_c.patch.
>
> Please don't mix code and whitespace changes, it's much harder to see
> the changes now.
>
> Derick
>
> --
>
> -------------------------------------------------------------------------
> Derick Rethans
> http://derickrethans.nl/
> PHP Magazine - PHP Magazine for Professionals
> http://php-mag.net/
> -------------------------------------------------------------------------
>