Re: php 4.3.0 ext/oci8 -- OCI_SHARED patch

"Thies C. Arntzen" <thies@thiesos.org> wrote... : > > I've modified the following files to allow for use of OCI_SHARED in ext/oci8 > > module if OCI8_VERSION >= 8.1, which will provide memory savings by sharing > > connection and statement data (refer to > > > > http://www.csee.umbc.edu/help/oracle8/server.815/a67846/basics.htm; > > search > > for "Shared Data Mode") between connections and statments respectively. I > > only have access to ext/oci8, so I can't check this in: Haven't really played with it, but the possiblity of some thread issues come into my mind. How have you tested it? > > configure > > main/php_config.h.in > > ext/oci8/config.m4 > > ext/oci8/oci8.ca > > there should be no nned to change anything outside ext/oci8/ > to make this work. configure is auto-generated. > > just go ahead and commit the stuff to ext/oci8 It should only be within the ext/oci8/oci8.c thing, I presume. We are talking about a flag for OCI(?)Logon function, right? > > Note: I'm not familiar enough with the windows distribution to add the mod > > there. > > neither am i. Unless it requires loading something particular during the compilation, windows distribution shouldn't differ in any way. What I still keep wondering is the thread safety of it. Also, since this is a ">= 8.1" thingie, you'd need to see whether it compiles and doesnt crash on lower versions of OCI (is OCI_SHARED defined in all OCIs? You need to control it for BC). -- Maxim Maletsky maxim@php.net