Re: [PATCH] SNMP value retrieval

HI, I have reviewed your patch and some comments I have are below, in perticular I was wondering what would be best to do so. *) I am not completely understanding what you want with the SNMP_VALUE_METHODPLAIN. Is this the BER encoded value?? If so that is a not wanted feature, IMHO. *) The object idea I like. *) I am not completely sure why or what you want to achieve by the 'REGISTER_LONG_CONSTANTS' where all the names have an 'ASN_' prefix?? The prefix does not make sense to a PHP-programmer, he should not need to know that level, I believe. OK, he must know whether it is a counter63, integer32 or integer32, that is different. Do I understand it correctly, that you want to be able to use the constant 'ASN_COUNTER' in the PHP langaue, for instance?? *) The value for the snmp_[get|set]_value_method I would think of a string. I beleive this is more user/PHP programmer friendly. I understand that the other that are boolean accept also an int, but those are boolean regards, Harrie ------------------------------------------------------------------ Author of MOD-SNMP, enabling SNMP management of Apache HTTP server