Re: Bug #21279 Karma request (Windows Bug)

Here is the compliant diff of the existing version Index: php_odbc.c =================================================================== RCS file: /repository/php4/ext/odbc/php_odbc.c,v retrieving revision 1.153 diff -u -r1.153 php_odbc.c --- php_odbc.c 24 Jan 2003 22:40:38 -0000 1.153 +++ php_odbc.c 6 Feb 2003 05:22:49 -0000 @@ -1589,7 +1589,7 @@ if (rc == SQL_SUCCESS_WITH_INFO) { Z_STRLEN_P(tmp) = result->longreadlen; } else if (result->values[i].vallen == SQL_NULL_DATA) { - Z_STRVAL_P(tmp) = IS_NULL; + ZVAL_NULL(tmp); break; } else { Z_STRLEN_P(tmp) = result->values[i].vallen; @@ -1599,7 +1599,7 @@ default: if (result->values[i].vallen == SQL_NULL_DATA) { - Z_STRVAL_P(tmp) = IS_NULL; + ZVAL_NULL(tmp); break; } Z_STRLEN_P(tmp) = result->values[i].vallen; "Ernani Joppert Pontes Martins" <ernani_listas@terra.com.br> escreveu na mensagem news:20030205152830.73217.qmail@pb1.pair.com... > > OK, I will change the Style of the comments > > But that's not the point. > > The point is that I need CVS Karma to commit it and I don't have. > > When I get it then I will make the unified diff and send to the list... > > TIA, > > Ernani > > > > > > "Joseph Tate" <jtate@mi-corporation.com> escreveu na mensagem > news:LMEBIGPOOEGLDHJJGLBBMEIAGNAA.jtate@mi-corporation.com... > > You need to use "C" style /*comments*/. > > > > Also, send a unified diff. Do this by running cvs diff -u <files you > > modified>. > > > > Joseph > > > > > -----Original Message----- > > > From: Ernani Joppert Pontes Martins [mailto:ernani_listas@terra.com.br] > > > Sent: Wednesday, February 05, 2003 10:05 AM > > > To: php-dev@lists.php.net > > > Subject: [PHP-DEV] Bug #21279 Karma request (Windows Bug) > > > > > > > > > Hi Rasmus, > > > > > > A Few months ago I was willing to help in bug fixes and bcompiler > > > development > > > > > > I solved the bug #21279 and now I need karma to commit my changes there > > > > > > I debbuged the file with the help of Manuel Lemos and I found the bug. > > > > > > Here is the diff: > > > > > > 1615: // Z_STRVAL_P(tmp) = empty_string; > > > 1616: ZVAL_NULL(tmp); > > > > > > 1626: // Z_STRVAL_P(tmp) = empty_string; > > > 1627: ZVAL_NULL(tmp); > > > > > > TIA and HTH, > > > > > > Ernani > > > > > > > > > > > > -- > > > PHP Development Mailing List > > > <http://www.php.net/> > > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > > > > > > >