Re: Bug #1961: execution functions.
| From: | Michael Gerdts | Date: | Wed, 04 Aug 1999 21:31:15 +0000 |
| Subject: | Re: Bug #1961: execution functions. | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-9522@lists.php.net to get a copy of this message | ||
On Wed, Aug 04, 1999 at 08:26:09PM -0000, webmaster@mlplus.com wrote:
> From: webmaster@mlplus.com
> Operating system: Windows 2000 or NT 5
> PHP version: 3.0.11
> PHP Bug Type: Other
> Bug description: execution functions.
>
> None of the functions that are meant to execute external programs work. I tested it out the
> execute the programs but when I want one to return a variable they never work. Please email me back
> with a fix or or a way for me to get around it.
>
I see that this is fixed in 3.0.12 (as already noted by Rasmus in the bugs
database), but it is still in the 4.0 CVS version.
What is the proper or polite way to handle getting that bug transferred
over to 4.0? Should the person that made the fix in 3.0 apply (and
presumably test) it, or should I make the change myself? I quite happily
don't have a Windows box to test the change on.
The change appears to be rather straightforward and I think that I could
get it right...
Mike
% cvs diff -r 1.83 -r 1.84 exec.c
Index: exec.c
===================================================================
RCS file: /repository/php3/functions/exec.c,v
retrieving revision 1.83
retrieving revision 1.84
diff -r1.83 -r1.84
29c29
< /* $Id: exec.c,v 1.83 1999/06/16 11:34:18 ssb Exp $ */
---
> /* $Id: exec.c,v 1.84 1999/07/16 18:05:00 jim Exp $ */
61a62,65
>
> #ifdef WIN32
> (void)AllocConsole(); /* We don't care if this fails. */
> #endif