Doc #67991 [Csd]: always_populate_raw_post_data deprecation warning buggy
| From: | tyrael@php.net | Date: | Mon, 27 Oct 2014 13:00:57 +0000 |
| Subject: | Doc #67991 [Csd]: always_populate_raw_post_data deprecation warning buggy | ||
| References: | 1 | Groups: | php.doc.bugs |
| Request: | Send a blank email to doc-bugs+get-11592@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=67991&edit=1
ID: 67991
Updated by: tyrael@php.net
Reported by: felix dot hassert+phpbugs at sevenval dot com
Summary: always_populate_raw_post_data deprecation warning
buggy
Status: Closed
Type: Documentation Problem
Package: *Web Server problem
Operating System: Debian Linux
PHP Version: 5.6.0
Assigned To: salathe
Block user comment: N
Private report: N
New Comment:
I'm not sure that the reworded sentence is better.
If I had to guess based on "will now generate an <constant>E_DEPRECATED</constant>
error when used", I would think that I should remove every reference for
always_populate_raw_post_data from my config/code to make this message to go away, which is not
true.
I think it would be better to describe what is actually happening:
the E_DEPRECATED will be generated when $HTTP_RAW_POST_DATA is populated which controlled by the
value of always_populate_raw_post_data (link to http://php.net/manual/en/ini.core.php where we
already describe in which case will $HTTP_RAW_POST_DATA be populated) and to remove the deprecated
message make sure that you don't use $HTTP_RAW_POST_DATA but php://input then you can disable
the population of $HTTP_RAW_POST_DATA via setting always_populate_raw_post_data to -1, which will
remove the E_DEPRECATED.
Previous Comments:
------------------------------------------------------------------------
[2014-10-26 16:30:29] salathe@php.net
Oops, wrong "quick fix" message...
This bug has been fixed in the documentation's XML sources. Since the
online and downloadable versions of the documentation need some time
to get updated, we would like to ask you to be a bit patient.
Thank you for the report, and for helping us make our documentation better.
------------------------------------------------------------------------
[2014-10-26 16:29:59] salathe@php.net
The fix for this bug has been committed.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
------------------------------------------------------------------------
[2014-10-26 16:29:42] salathe@php.net
Automatic comment from SVN on behalf of salathe
Revision: http://svn.php.net/viewvc/?view=revision&revision=335142
Log: auto_populate_raw_post_data generates E_DEPRECATED when *used* (doc bug #67991)
------------------------------------------------------------------------
[2014-09-10 10:56:56] mike@php.net
It should read
"... will now generate an E_DEPRECATED error when used" instead of
"... will now generate an E_DEPRECATED error when enabled"
The "enabled" was taken from UPGRADING, sorry.
------------------------------------------------------------------------
[2014-09-10 07:35:10] felix dot hassert+phpbugs at sevenval dot com
This seems to be related to https://wiki.php.net/rfc/slim_post_data (found
via #66763).
If I read the slim_post_data proposal correctly, I do understand, why this happens. In my case, no
content-type is present. Thus the "always" in aprpd is different when using 0 or -1.
However, the 5.6 migration docs was misleading me, because I did not _enable_ the flag.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=67991
--
Edit this bug report at https://bugs.php.net/bug.php?id=67991&edit=1