Bug #65272 [Csd]: flock() documentation says LOCK_NB is not available on Windows, although it is

Edit report at https://bugs.php.net/bug.php?id=65272&edit=1 ID: 65272 Updated by: ab@php.net Reported by: benjamin dot morel at gmail dot com Summary: flock() documentation says LOCK_NB is not available on Windows, although it is Status: Closed Type: Bug Package: Documentation problem Operating System: N/A PHP Version: Irrelevant Assigned To: ab Block user comment: N Private report: N New Comment: @rdlowrey, pushed an improvement. Tests pass. Thanks. Previous Comments: ------------------------------------------------------------------------ [2015-02-21 12:34:12] ab@php.net @rdlowrey, this fix seems to be not correct. ERROR_INVALID_BLOCK has nothing to do with locking. Thanks. ------------------------------------------------------------------------ [2015-02-02 18:46:13] peehaa@php.net The docs are updated to reflect the fact that LOCK_NB does indeed work on Windows systems. I also have a docs patch ready when rdlowrey's changes are released. ------------------------------------------------------------------------ [2015-02-02 16:43:58] benjamin dot morel at gmail dot com @rdlowrey Who should update the documentation? ------------------------------------------------------------------------ [2015-02-02 16:38:40] rdlowrey@php.net This is a documentation bug, but it's also a problem in the actual implementation in windows environments. The error constant used to determine the value of $wouldblock is different in windows than other environments. This issue has been corrected in 5.5 and up. The implementation should now be consistent across all platforms and the documentation should be updated appropriately. ------------------------------------------------------------------------ [2015-02-02 16:31:46] rdlowrey@php.net Automatic comment on behalf of rdlowrey Revision: http://git.php.net/?p=php-src.git;a=commit;h=f2f467bd9609f5fad2491a4718380fadaa449470 Log: Fixed bug #65272: correctly set flock() out param in windows ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=65272 -- Edit this bug report at https://bugs.php.net/bug.php?id=65272&edit=1