Doc #70050 [Ana]: set_exception_handler receives non-exception objects

Edit report at https://bugs.php.net/bug.php?id=70050&edit=1 ID: 70050 Updated by: trowski@php.net Reported by: mfischer@php.net Summary: set_exception_handler receives non-exception objects Status: Analyzed Type: Documentation Problem Package: *General Issues Operating System: Ubuntu 14.04.2 LTS PHP Version: 7.0.0beta1 Block user comment: N Private report: N New Comment: I think this issue is best addressed by clear documentation that upgrading to PHP 7 will require the type declaration on exception handlers to be changed from Exception to Throwable. It should be noted that an Error object and any future implementor of Throwable are still exceptions, they just aren't instances of Exception. :) I apologize for the documentation nightmare, but this isn't without precedence in other languages such as Python and Java. Previous Comments: ------------------------------------------------------------------------ [2015-07-13 20:31:19] ab@php.net As for me - what is bad is the name set_exception_handler which now catches Trowable indeed. But IMHO - not invoking it only because of name is not handy. Then users have no catch all solution. Given a similar issue exists in php5, IMHO it is a topic of documentation. It is too late to change names or introducing a better solution in 7.0 :( Thanks. ------------------------------------------------------------------------ [2015-07-13 07:15:45] laruence@php.net Actually, I am kindof understand this problem. and maybe we should do some improvements. that is, if the exception be throw is not an compatible exception type of exception_handler. then the exception handler should not be called. actually, this problem is also exists in php5, like <?php set_exception_handler( function (ExceptionA $e) { var_dump('yodo'); } ); class exceptionA extends exception{}; throw new Exception("xxx"); ------------------------------------------------------------------------ [2015-07-12 11:03:05] mfischer@php.net > So what you're saying is that we need to make sure all of that documentation gets updated > to reflect the new Throwable stuff, right? No, I'm saying there's a BC problem. >> everything which is thrown should be of type \Exception > But... you already know this won't be the case: you voted in favor of the engine > exceptions RFC. I don't see the relevancy here. But since you insist on this point: I voted against introducing a BaseException. TBH I forgot about this RFC and how I voted and was kind of independently hit by this issue, which to no-surprise matches how I voted and validates my past choice. thanks, - Markus ------------------------------------------------------------------------ [2015-07-12 10:20:26] requinix@php.net So what you're saying is that we need to make sure all of that documentation gets updated to reflect the new Throwable stuff, right? >everything which is thrown should be of type \Exception But... you already know this won't be the case: you voted in favor of the engine exceptions RFC. Which clearly said that there will be a hierarchy of exceptions above Exception. And there was all the discussion about this on the internals list. ------------------------------------------------------------------------ [2015-07-12 10:11:57] mfischer@php.net Description: ------------ A callable set with "set_exception_handler" receives objects which are not of type Exception. Why is the "Exception" in the example script typehinted? Why not, the documentation states: "This handler function needs to accept one parameter, which will be the exception object that was thrown." Which is not true anymore. I welcome "Fatal error" being turned into something which is handleable, but this seems like a BC break and IMHO everything which is thrown should be of type \Exception . Test script: --------------- <?php set_exception_handler( function (Exception $e) { var_dump('yodo'); } ); Foo::bar; Expected result: ---------------- The handler should receive something which is an "Exception", not an "Error" object. Actual result: -------------- $ php test.php Fatal error: Uncaught TypeError: Argument 1 passed to {closure}() must be an instance of Exception, instance of Error given in /vagrant/api.swat.io/test.php:3 Stack trace: #0 [internal function]: {closure}(Object(Error)) #1 {main} thrown in /vagrant/api.swat.io/test.php on line 3 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=70050&edit=1