Bug->Doc #71053 [ReO]: Type Hint about DateTime::diff does not match with informed
| From: | laruence@php.net | Date: | Wed, 09 Dec 2015 14:40:23 +0000 |
| Subject: | Bug->Doc #71053 [ReO]: Type Hint about DateTime::diff does not match with informed | ||
| References: | 1 | Groups: | php.doc.bugs |
| Request: | Send a blank email to doc-bugs+get-12923@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=71053&edit=1
ID: 71053
Updated by: laruence@php.net
Reported by: gabriel dot heming at hotmail dot com
Summary: Type Hint about DateTime::diff does not match with
informed
Status: Re-Opened
-Type: Bug
+Type: Documentation Problem
Package: Date/time related
Operating System: Debian 8.2
PHP Version: 7.0.0
Block user comment: N
Private report: N
New Comment:
then what the problem if we change bool to int in doc?
thanks
Previous Comments:
------------------------------------------------------------------------
[2015-12-09 13:35:28] gabriel dot heming at hotmail dot com
If the PHP 7 was builded to be faster and more strict, why this could be accepted as a doc bug?
I mean how could be more than a value, since the manual say about a boolean, how someone could use
an integer instead?
------------------------------------------------------------------------
[2015-12-09 04:04:22] laruence@php.net
I reverted the fix, because it break common used
$data->diff($data2, 1);
I'd prefer doc bug instead.
thanks
------------------------------------------------------------------------
[2015-12-09 04:01:29] laruence@php.net
Automatic comment on behalf of laruence@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f248309b7485fea08e3c112adab97bfa1fc74df4
Log: Revert "Fixed bug #71053 (Type Hint about DateTime::diff does not match with
informed)"
------------------------------------------------------------------------
[2015-12-09 03:50:14] reeze@php.net
@requinix I agree with you. It is a bug, at least in strict types context, there might be more cases
in repo like this. I will try to find them.
------------------------------------------------------------------------
[2015-12-09 03:44:23] reeze@php.net
Automatic comment on behalf of reeze
Revision: http://git.php.net/?p=php-src.git;a=commit;h=943b23dcf6666a708c2ad4470cad5db36d47683a
Log: Fixed bug #71053 (Type Hint about DateTime::diff does not match with informed)
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=71053
--
Edit this bug report at https://bugs.php.net/bug.php?id=71053&edit=1