Doc #72549 [Asn]: typos

Edit report at https://bugs.php.net/bug.php?id=72549&edit=1 ID: 72549 Updated by: cmb@php.net Reported by: ed at takken dot us Summary: typos Status: Assigned Type: Documentation Problem Package: Documentation problem Operating System: OS X 10.11.5 PHP Version: 5.5.37 Assigned To: cmb Block user comment: N Private report: N New Comment: > […] (sorry!) so I guess it can be closed. No problem; PR closed. :-) > Or, if something really has to be done, then to go for "had > been". Looks good to me. Thanks for the interesting post, Damian. :-) Previous Comments: ------------------------------------------------------------------------ [2016-07-13 02:22:42] kalle@php.net I got some SVN auth issues for some reason, so I'll assign you the docblock since I so rudely took the wen bug from you Chris >.< ------------------------------------------------------------------------ [2016-07-13 01:50:25] kalle@php.net @cmb seems like I was too quick on fixing the web before I saw your PR (sorry!) so I guess it can be closed. @requinix I don't see why we cannot fix simple typos like this, even simple typos can often lead to products or project looking less professional, or in some edge cases, less trustworthy. I'm not a native english speaker either, however I do like that we have consistency and try to be our best, heck I'm not even that great at my own native grammar (danish), but I do try to improve myself to actually speak "correctly" and make it less a burden for others to read. Together maybe we can prevent another "ALL YOUR BASE ARE BELONG TO US" ;-) ------------------------------------------------------------------------ [2016-07-06 15:06:25] requinix@php.net Sometimes I hate this language... and by that I mean English, of course. Conditional, sure, but were/was is a matter for present unreal conditional tense ("were" grammatically correct, "was" used in conversational English), and here I think it's more of a past unreal conditional. I haven't seen any examples of was/were used with the latter - most saying "had been" instead. But past/present itself is debatable: while it's clear that the sentence is referring to behavior that mysql_query will perform (future simple), it could be suggesting that the behavior promises a result equivalent to the developer having called mysql_connect previously (past unreal conditional) or it could be suggesting that the function will behave as if mysql_connect was being called at that moment (present unreal conditional). Both of those are true. Actually, "present unreal conditional" isn't quite the case. PHP effectively *does* call mysql_connect, albeit by way of the internal C functions rather than literally the developer-facing "mysql_connect" function (with only a handful of layers of indirection involved). So you could say that it's present real conditional because PHP is, in fact, calling mysql_connect at that time, thus making the action "real". And that "future simple" from earlier? That's debatable too as it can vary based on how you* view the documentation: do you look to the documentation to tell you how mysql_query will behave when you call it, or do you look to see what mysql_query would do if you were to use it? The former is future simple** while the latter is future real conditional***. (* And by "you" I mean the informal impersonal pronoun. Not specifically @ed or @cmb or the reader of this absurdly long comment.) (** Assume that the code which calls mysql_query has already been written. This could be present real conditional except the code is not actually executing at the moment (unless you're stepping through it with a debugger at that moment...). It could be future real conditional except the very fact that you're writing the code implies that the code will, in fact, execute in the future - perhaps not every time, but it is certain that it will sometime. That said, it could be future conditional if you were to also simultaneously consider the context of your use of the function and thus any potential conditional logic involved. Regardless, I thus conclude it's future simple.) (*** That may seem weird since one's use of the function is not yet established, but English has this awkward thing where future real conditional covers pretty much all the future conditional usages, reserving future unreal conditional for situations where the speaker wants to draw attention to an impossible premise.) My vote is for not wasting any more time on the clusterf*** that is English grammar and its tenses. Or, if something really has to be done, then to go for "had been". ------------------------------------------------------------------------ [2016-07-06 13:20:15] cmb@php.net Thanks for the bug report. I've submitted a PR wrt. the first typo. My English skills are not sufficient to assess the other issue. ------------------------------------------------------------------------ [2016-07-05 23:12:41] ed at takken dot us Description: ------------ On page: https://bugs.php.net Made sure you are using the latest stable version should be: Make sure you are using the latest stable version On page: http://php.net/manual/en/function.mysql-query.php For conditional tense, do not use: it will try to create one as if mysql_connect() was called Instead use: it will try to create one as if mysql_connect() were called Test script: --------------- On page: https://bugs.php.net Made sure you are using the latest stable version should be: Make sure you are using the latest stable version On page: http://php.net/manual/en/function.mysql-query.php For conditional tense, do not use: it will try to create one as if mysql_connect() was called Instead use: it will try to create one as if mysql_connect() were called ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=72549&edit=1